Envs for VAULT_ADDR and VAULT_TOKEN should not be reqd #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the injector is configured with an external vault address and kubernetes and the kubernetes auth backend is correctly configured with the role there should be no need to expose VAULT_ADDR and VAULT_TOKEN as part of the env as well as commit to git (if necessary). It would kill the whole point of the injector.
Also please correct your learn guide where it says
Followed by
cat patch-02-inject-secrets.yml
The filename following the
cat
command is incorrect and should bepod-devwebapp-with-annotations.yaml