Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent flags and CI for --write-secrets=false #100

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Jun 2, 2021

This PR makes our flags consistent on using dashes instead of underscores as with our other products. To help support that in a forwards-compatible way, I've left --health_addr in there for now (because it's the only underscore argument we've released) but marked it as deprecated, and if someone specifies both --health_addr and --health-addr, the one that occurs later in the command line wins.

This PR also adds a couple of make targets and updated CI config to support running tests with both behaviours of --write-secrets. It's a pretty significant change in the operation of the provider because it controls whether the provider or the driver writes the secrets, so I'd like to keep good test coverage of both flows until --write-secrets=true becomes a deprecated behaviour a few versions down the line.

Both of these entries will get an advanced notice in our next release changelog explaining that they will be a breaking change in a future release, but both can also be fixed by users well ahead of time once the next release is out.

@tomhjp tomhjp requested review from tvoran and jasonodonnell June 2, 2021 17:47
@tomhjp
Copy link
Contributor Author

tomhjp commented Jun 2, 2021

I've put a note in the changelog slating --write-secrets=false as the default in 2 major versions from now, as the driver is looking for providers to support it as the default by v0.0.23 which is roughly a month away. See kubernetes-sigs/secrets-store-csi-driver#551 for context.

Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomhjp tomhjp merged commit 511e459 into master Jun 3, 2021
@tomhjp tomhjp deleted the test-and-tidy branch June 3, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants