Consistent flags and CI for --write-secrets=false #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our flags consistent on using dashes instead of underscores as with our other products. To help support that in a forwards-compatible way, I've left
--health_addr
in there for now (because it's the only underscore argument we've released) but marked it as deprecated, and if someone specifies both--health_addr
and--health-addr
, the one that occurs later in the command line wins.This PR also adds a couple of
make
targets and updated CI config to support running tests with both behaviours of--write-secrets
. It's a pretty significant change in the operation of the provider because it controls whether the provider or the driver writes the secrets, so I'd like to keep good test coverage of both flows until--write-secrets=true
becomes a deprecated behaviour a few versions down the line.Both of these entries will get an advanced notice in our next release changelog explaining that they will be a breaking change in a future release, but both can also be fixed by users well ahead of time once the next release is out.