Mask each line of multi-line secrets #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I think we usually wait to commit dist/index.js until a release. |
There was a problem hiding this comment.
LGTM, but @tvoran is right, please remove the compiled index.js changes and we'll do that when we're ready to release.
Co-authored-by: Jason O'Donnell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205.
When fetching multi-line secrets from Vault, the secret was not being properly registered with GH actions for masking in the output logs. See the linked issue for full details - the fix itself is fairly trivial.
Still todo:
[ ] Determine whether the largeindex.jsdiff is problematic, looks like I probably have some different local versions installed to the previous builder