Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call mstsc.exe Windows RDP client in WSL #9758

Merged
merged 1 commit into from
May 3, 2018

Conversation

StefanScherer
Copy link
Contributor

Running vagrant rdp in WSL only tries to run the Linux RDP clients xfreerdp or rdesktop.

I've added the code from the Windows RDP capability into the Linux rdp.rb.

It recognizes that Vagrant is running in WSL and then uses mstsc.exe as fallback if the user hasn't installed the other Linux RDP clients. So WSL users have the chance to use the Linux RDP client, but it also just works with the Windows RDP client.

Improves #9628

@StefanScherer
Copy link
Contributor Author

I tried it manually with

sudo vi /opt/vagrant/embedded/gems/2.0.4/gems/vagrant-2.0.4/plugins/hosts/linux/cap/rdp.rb

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@chrisroberts chrisroberts merged commit 89d00f4 into hashicorp:master May 3, 2018
@StefanScherer StefanScherer deleted the wsl-rdp branch May 3, 2018 20:10
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants