Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox: handle a list of bridged nics #5691

Merged
merged 1 commit into from
May 30, 2015

Conversation

bergman
Copy link
Contributor

@bergman bergman commented May 7, 2015

This change allows you to specify multiple network interfaces to bridge to in the order you want them tried, picking the first match.

VAGRANTFILE_API_VERSION = "2"

Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
  # ...
  config.vm.network "public_network",
    bridge: ["en4: Thunderbolt Ethernet",
             "en6: Broadcom NetXtreme Gigabit Ethernet Controller",
             "en0: Wi-Fi (AirPort)"]
  # ...
end

This change allows you to specify multiple network interfaces to bridge
to, picking the first found.

```ruby
config.vm.network "public_network",
  bridge: ["en4: Thunderbolt Ethernet",
           "en6: Broadcom NetXtreme Gigabit Ethernet Controller",
           "en0: Wi-Fi (AirPort)"]
```
@berendt
Copy link
Contributor

berendt commented May 14, 2015

This new behavior should be documented in website/docs.

@bergman
Copy link
Contributor Author

bergman commented May 15, 2015

@berendt I am not familiar with this project enough to know how differences between virtualization providers are handled. This change only applies to virtualbox and the documentation seem to make no difference, at least not in the file I thought was relevant website/docs/source/v2/networking/public_network.html.md. Should this feature be added to all other providers as well, documented as virtualbox only, or not documented at all?

@sethvargo sethvargo merged commit 2b34119 into hashicorp:master May 30, 2015
@berendt
Copy link
Contributor

berendt commented May 31, 2015

@sethvargo @mitchellh I do not understand the review/merge policy of Vagrant. For some PRs it is necessary to add documentation, for some PRs it is not necessary (like this one). After the merge of this PR this feature is now undocumented at https://docs.vagrantup.com/v2/networking/public_network.html. How should a user now be aware of this new feature? At the moment he has to read the sources to find this feature. I think there are some more features not documented at the moment and I do not like this.

@bergman I am also not familiar with this project, sorry for not replying to your comment. I hoped that @sethvargo will take care of the comment...

legal90 added a commit to legal90/vagrant-parallels that referenced this pull request Nov 22, 2015
@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants