provider/aws: Fix issue changing EIP Association

[catsby]

Fix issue when moving an EIP from one Instance to another.
Currently, we provide the PrivateIpAddress in the AssociateAddress call, but we're sending the private IP of the current instance, not the instance we're targeting. Since private_ip is computed, on association we get the PrivateIp of the first Instance here, which incorrectly get's thrown in with the request.

Fixes #6436 and failing test TestAccAWSEIP_instance

Update

Chatted with @phinze about the possible/likely conflict with #6070 and we've got a plan for going forward. I will re-work this PR and update soon

More Update:

I've implemented what @phinze and I discussed:

• remove private_ip as a user specified value: this value is once again computed and reflects the current private ip
• added associate_with_private_ip: this is a private IP you designate to associate the EIP with.

Private IP is a computed attribute, meaning it will pick up it's value from the Instance or Network Interface that the EIP is associated with. The associate_with_private_ip allows the users to specify what value the EIP should take. Without distinguishing between the two cases, we're unable to move the EIP from Instance to Instance (see #6436 and TestAccAWSEIP_instance test)

[catsby]

Tests are green:

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEIP_ -timeout 120m
=== RUN   TestAccAWSEIP_basic
--- PASS: TestAccAWSEIP_basic (10.44s)
=== RUN   TestAccAWSEIP_instance
--- PASS: TestAccAWSEIP_instance (156.02s)
=== RUN   TestAccAWSEIP_network_interface
--- PASS: TestAccAWSEIP_network_interface (32.28s)
=== RUN   TestAccAWSEIP_twoEIPsOneNetworkInterface
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (32.19s)
=== RUN   TestAccAWSEIP_associated_user_private_ip
--- PASS: TestAccAWSEIP_associated_user_private_ip (143.78s)
PASS
ok      github.com/has

[phinze]

LGTM!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.