[WIP] Add Triton CNS tag support.

[sodre]

The code does an invertible transformation of the Triton CNS tags
effectively mapping _ -> __ followed by . -> _.

Suggested modification to address #5836.

[sodre]

One of the reasons why the AccTest is failing is because of GH-6148.
I am working to get that fixed as well.

[sodre]

@stack72, I want to expose a field called "DomainNames" which is an array of strings derived from the machine name and the tag values of triton_cns_services.

What is the best way to include a resource feature that is "read-only" ? Should I include it in the schema and set Computed to true? Is there a way to return it as an output variable, if so can you point me to an example in code that does that?

Thank you.

[stack72]

Hi @sodre

Not sure what you mean by readonly? Do you mean that get's returned from the API only and cannot be set by the user?

P.

[sodre]

Hi Paul,

Exactly what you said. It can’t be set directly by the user.

Patrick

On Apr 20, 2016, at 7:50 PM, Paul Stack [email protected] wrote:

Hi @sodre https://github.com/sodre
Not sure what you mean by readonly? Do you mean that get's returned from the API only and cannot be set by the user?

P.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #6115 (comment)

[stack72]

https://github.com/hashicorp/terraform/blob/master/builtin/providers/azurerm/resource_arm_sql_server.go#L54 This should work for you :)

[sodre]

Thanks!

I’ll make the mods and check it in with tests this weekend.

Patrick

On Apr 20, 2016, at 7:53 PM, Paul Stack [email protected] wrote:

https://github.com/hashicorp/terraform/blob/master/builtin/providers/azurerm/resource_arm_sql_server.go#L54 https://github.com/hashicorp/terraform/blob/master/builtin/providers/azurerm/resource_arm_sql_server.go#L54 This should work for you :)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #6115 (comment)

[stack72]

👍

[sodre]

I am investigating if PR #6322 fixes the issue for us as well. If it does then there is no need to use my transformation.

[stack72]

Hi @sodre

Any thoughts on whether we still need this PR?

P.

[sodre]

Hi Paul,

I tested one of the fixes that supports '.' and it did not work for me.

I am without a computer until Sunday night, I'll retest it.

Patrick

Sent from my iPhone

On May 20, 2016, at 5:14 AM, Paul Stack [email protected] wrote:

Hi @sodre

Any thoughts on whether we still need this PR?

P.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[stack72]

No worries :)

On Fri, May 20, 2016 at 1:51 PM, Patrick Sodré [email protected]
wrote:

Hi Paul,

I tested one of the fixes that supports '.' and it did not work for me.

I am without a computer until Sunday night, I'll retest it.

Patrick

Sent from my iPhone

On May 20, 2016, at 5:14 AM, Paul Stack [email protected]
wrote:

Hi @sodre

Any thoughts on whether we still need this PR?

P.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6115 (comment)

[stack72]

Hi @sodre

ping :) Anything you need here?

P.

[sodre]

Hi @stack72,
The code as is works fine for me. My only hesitation on taking the WIP tag out because @jen20 suggested in #2143 that the code in #6322 would fix this issue for everyone.

Unfortunately, it was not clear to me how the fix translated to what gets written in the terraform config files, or whether it required modifications to the provider code. I never heard back from @jen20 on how he was able to get it to work for his case.

I will leave it up to you. The worst case is having to undo the change in a future release and deprecate the transformation my code currently implements.

Patrick

[sodre]

@stack72 the code is ready from my side.

[sodre]

@stack72 and @jen20,
I am withdrawing this pull request in favor of #7149 and #7130.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.