terraform test: don't remove sensitive marks from inputs #35021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Terraform plan functionality forbade input values with sensitive marks. The testing framework avoided this by removing the sensitive marks from inputs, and printing a warning if the input variable was not marked as sensitive. As of #34414 the terraform plan can now handle sensitive marks on input values. This means the testing framework no longer needs to remove sensitive marks, and warn users about the sensitive metadata being lost.
There's also a flyby refactoring of the tests in test_test.go to remove the init output from the expected/actual comparisons introduced as part of the recent
init
command refactoring. We don't care about validating the init output for theses tests.Fixes #35011
Target Release
1.9.0
Draft CHANGELOG entry
ENHANCEMENTS
terraform test
: The test framework can now maintain sensitive metadata between run blocks.