client-side implementation of provider functions #34385
Conversation
Add the types, methods, and basic framework to use provider defined functions.
| } | ||
| args[i] = argVal | ||
| } | ||
| } |
There was a problem hiding this comment.
I can see we're checking for too many parameters here, but what happens if we don't have enough parameters in the request?
| if len(r.Arguments) < len(funcDecl.Parameters) { | ||
| resp.Diagnostics = resp.Diagnostics.Append(fmt.Errorf("not enough arguments for function %q", r.FunctionName)) | ||
| return resp | ||
| } |
There was a problem hiding this comment.
Oh, I think this answers my question above, unless I'm misunderstanding!
|
Marks are automatically handled by the cty function call implementation (called via a function expression within hcl), which transfers the marks from the arguments to the result. |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR build on #34383, adding the machinery to handle the new provider defined functions in the update protocol. We add the grpc handling code, add internal interface types and methods, and and flush out the various internal implementations which fulfill the provider interface.