Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: support multiple shared config/credentials files #33723

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 22, 2023

Adds the shared_config_files and shared_credentials_files parameters and adds support for default AWS environment variables for credentials and configuration files, AWS_CONFIG_FILE and AWS_SHARED_CREDENTIALS_FILE. This deprecates the shared_credentials_file parameter.

% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 102.007s

Relates #30493

Target Release

1.6.0

Draft CHANGELOG entry

UPGRADE NOTES

@jar-b jar-b requested a review from a team as a code owner August 22, 2023 21:01
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@jar-b jar-b merged commit 501305d into s3/modernization Aug 23, 2023
@jar-b jar-b deleted the s3/shared-cfg-cred-files branch August 23, 2023 14:18
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants