Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: Updates aws-sdk-go-base to v2 #33631

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Aug 4, 2023

Updates the aws-sdk-go-base dependency to v2 and uses the AWS SDK for Go v2 for AWS API calls.

Note: This does not preserve the current legacy authentication flow, which will be added in a separate PR. This is currently a breaking change.

Related #30443

Target Release

1.6

Draft CHANGELOG entry

Will have no user-facing changes once accompanying work to preserve the legacy authentication flow is complete.

@gdavison gdavison requested a review from a team as a code owner August 4, 2023 00:55
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ TF_ACC=1 go test ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 101.331s

@gdavison gdavison merged commit 62a04cf into s3/modernization Aug 10, 2023
@gdavison gdavison deleted the s3/update-aws-sdk-base branch August 10, 2023 18:03
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants