docs: "How Terraform Uses Unicode" should mention HCL too #32231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this on my first attempt to write this document. Consequently we're currently depending on a version of HCL which uses Unicode 9, and that's significantly lagging behind everything else which is currently on Unicode 13. My goal of adding these docs then is to remind us to update HCL to Unicode 15 once we're updating everything else to Unicode 15 with the Go 1.20 release, assuming that the Go team completes that Unicode upgrade as currently planned.
apparentlymart
force-pushed
the
doc-unicode-hcl
branch
from
9902942 to
53efa7f
Compare
jbardin
approved these changes
Nov 16, 2022
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this on my first attempt to write this document. Consequently we're currently depending on a version of HCL which uses Unicode 9, and that's significantly lagging behind everything else which is currently on Unicode 13.
My goal of adding these docs then is to remind us to update HCL to Unicode 15 once we're updating everything else to Unicode 15 with the Go 1.20 release, assuming that the Go team completes that Unicode upgrade as currently planned (golang/go#55079).