google: Add google_compute_backend_service

[radeksimko]

Test plan

$ make testacc TEST=./builtin/providers/google TESTARGS='-run=ComputeBackendService' 2>~/tf.log

go generate ./...
TF_ACC=1 go test ./builtin/providers/google -v -run=ComputeBackendService -timeout 90m
=== RUN TestAccComputeBackendService_basic
--- PASS: TestAccComputeBackendService_basic (21.27s)
=== RUN TestAccComputeBackendService_withBackend
--- PASS: TestAccComputeBackendService_withBackend (125.31s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 146.588s

[sparkprime]

Awesome!

[radeksimko]

@sparkprime Does Awesome == LGTM, i.e. do you not have any reservations about the code? :)

[sparkprime]

I haven't looked at it in detail yet but will do very soon (hopefully today) :)

[sparkprime]

Note: some day this would be good to factor out and apply to all resources

[radeksimko]

Factor out what exactly? That validation function you mean?

[sparkprime]

Yeah, it'd be useful for all resources

On Sat, Aug 22, 2015, 5:11 PM Radek Simko [email protected] wrote:

In builtin/providers/google/resource_compute_backend_service.go
#3038 (comment):

•           Type:     schema.TypeString,
  

•           Optional: true,
  

•       },
  

•       "health_checks": &schema.Schema{
  

•           Type:     schema.TypeSet,
  

•           Elem:     &schema.Schema{Type: schema.TypeString},
  

•           Required: true,
  

•           Set:      schema.HashString,
  

•       },
  

•       "name": &schema.Schema{
  

•           Type:     schema.TypeString,
  

•           Required: true,
  

•           ForceNew: true,
  

•           ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) {
  

Factor out what exactly? That validation function you mean?

—
Reply to this email directly or view it on GitHub
https://github.com/hashicorp/terraform/pull/3038/files#r37699801.

[sparkprime]

Other than that minor stuff LGTM

[radeksimko]

@sparkprime Modifications done, check my explanation regarding TypeSet/TypeList.

[sparkprime]

LGTM merge it :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.