Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove state lock flags from init #27464

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Remove state lock flags from init #27464

merged 1 commit into from
Jan 11, 2021

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Jan 11, 2021

[these were flagged for removal in the command audit, I'm going to describe what I think the reasoning is]

The state lock flags are not relevant in the init flow, and are thus removed.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #27464 (bbcf6ae) into master (aab0dd1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
command/init.go 61.60% <ø> (-0.06%) ⬇️
internal/providercache/dir.go 67.34% <0.00%> (-6.13%) ⬇️
states/statefile/version4.go 58.19% <0.00%> (+0.23%) ⬆️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️

@pselle pselle requested a review from a team January 11, 2021 18:21
@pselle pselle merged commit 462caaf into master Jan 11, 2021
@pselle pselle deleted the pselle/init-lock branch January 11, 2021 19:54
@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants