Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Update go-getter to v1.5.1 with support for vhost style S3 paths into v0.14 #26916

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #26914 to be assessed for backporting due to the inclusion of the label 0.14-backport.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Aims to fix #24656 and related to hashicorp/go-getter#263

@teamterraform teamterraform requested a review from picatz November 13, 2020 16:38
@hashicorp hashicorp deleted a comment from hashicorp-cla Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #26916 (d1cd9da) into v0.14 (367027e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/node_resource_plan.go 97.19% <0.00%> (+1.86%) ⬆️
internal/providercache/dir.go 73.46% <0.00%> (+6.12%) ⬆️

@pselle pselle merged commit 500a095 into v0.14 Nov 13, 2020
@pselle pselle deleted the backport/update-go-getter/badly-known-squirrel branch November 13, 2020 16:50
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • pselle
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@ghost
Copy link

ghost commented Dec 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants