Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import message to 'prepared' #20018

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

YakDriver
Copy link
Member

Fixes #20017

Changes proposed:

  • hook_ui: Change the "Import complete!" message to "Import prepared!" and then list resources as "prepared" instead of "imported".

command/hook_ui.go Outdated Show resolved Hide resolved
@mildwonkey
Copy link
Contributor

Hi @YakDriver , thanks for working on this!

This is indeed a confusing message. It's meant to indicate that the item has been imported to the current state, pending successful refresh, but (as you already noted) that just isn't clear.

I went back and forth for a bit on the message - Import staged? Imported to state? - but you had a good idea with Import prepared. I left one small nitpicky suggestion for the next message. Let me know what you think.

I know it's been awhile since you submitted this PR. If you don't have the time or inclination to look at this again, that's ok! I can make that small change myself and merge this for you.
Thanks again!

Co-Authored-By: Kristin Laemmert <[email protected]>
@YakDriver
Copy link
Member Author

@mildwonkey I like it. As long as it clears up the confusion, I'm happy.

@mildwonkey
Copy link
Contributor

Great, thank you @YakDriver !

The travis build did pass - it's still showing up as 'in progress', at least from my browser - so I will merge this now. 🎉

@ghost
Copy link

ghost commented Aug 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Import completed!" message is wrong
3 participants