Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update kardianos/osext to support android #19529

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

arno01
Copy link
Contributor

@arno01 arno01 commented Dec 2, 2018

In order to get rid of Couldn't start Terraform: ExecPath not implemented for android

@apparentlymart
Copy link
Contributor

Hi @arno01!

I'm happy to merge this since it seems like a harmless and useful update in general, but I'm also curious to understand what your motivations are here... Android isn't a supported platform for Terraform and we don't have any testing procedures for it, so it's likely that future versions of Terraform will inadvertently break Android compatibility in other ways.

@apparentlymart apparentlymart added the dependencies Auto-pinning label Dec 3, 2018
@arno01
Copy link
Contributor Author

arno01 commented Dec 4, 2018

Hi @apparentlymart , I know that Android isn't a supported platform for Terraform, but with this PR Terraform is actually working on Android. Since the PR is harmless, I bet some people who use Android for their work would be happy to see Terraform is just working.

My main motivation is that I switched to Android device (Samsung DeX) for work and am really happy about it, so Terraform would be one of the last missing pieces for me :-)

And I don't understand why Android (ARM) isn't a supported platform for Terraform? Can this be changed?

@apparentlymart
Copy link
Contributor

Each new platform we support adds additional maintenence and testing overhead and requires us to have infrastructure on which to test, so we need to prioritize which platforms serve the most users. If there were a significant number of people wanting to run Terraform on Android then it could change, but you are the first person that's ever mentioned attempting it!

For now I will merge this, since as I said it's a harmless change to merge, but I can't promise that all future versions of Terraform will continue to build on Android without further changes. As long as it continues to work without any extra effort we certainly won't make any effort to stop you building it on Android, and if a larger cohort of Android users develops we can discuss finding ways for us to do automated testing against Android, writing up installation instructions, and other such things that users expect for officially-supported platforms.

@apparentlymart apparentlymart merged commit 98c8ac0 into hashicorp:master Dec 4, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants