Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for path style S3 bucket address #16393

Closed
wants to merge 1 commit into from

Conversation

mevansam
Copy link

Added flag to allow s3 bucket address to be created with bucket name in path i.e. http(s)://s3.amazonaws.com//. This style of addressing is required by non-AWS S3 distributions such as Minio.

…in path i.e. http(s)://s3.amazonaws.com/<bucket>/<object>. This style of addressing is required by non-AWS S3 distributions such as Minio.
@bhood4
Copy link

bhood4 commented Nov 3, 2017

Nice. I need this as well for MOS Openstack/Ceph S3, and was just about to do something similar.

Maybe terraform/website/docs/backends/types/s3.html.md could use an extra line:

  • s3_force_path_style - (Optional) Force path-style instead of virtual-hosted–style URLs to access a bucket. Default is false for virtual-hosted–style URLs.

@luyaor
Copy link

luyaor commented Jul 17, 2018

Hi Mevan Samaratunga(@mevansam) & @bhood4,
We are working on identifying redundant development and duplicate pull requests. We have found there is a pull request: #17001 which might be duplicate to this one and already merged into main stream. So maybe this pull request could be closed.

We would really appreciate if you could help us to validate and give us some feedback. Thank you very much for your time!

@bflad
Copy link
Contributor

bflad commented Dec 17, 2018

Hi @mevansam 👋 Thanks so much for submitting this. It appears this was accidentally missed in previous review cycles for the S3 backend code. Another similar pull request, #17001, was merged with the same functionality (albeit the configuration was named force_path_style instead of s3_force_path_style). The force_path_style configuration for the S3 backend has been available in Terraform since 0.11.2, although its been missing from the Terraform website documentation (as of this writing, up to 0.11.11) as noted in #19672, which will be fixed up shortly.

Apologies again for the review miss here and thanks for your contribution.

@bflad bflad closed this Dec 17, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants