Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Add example of vm from user image #14231

Merged

Conversation

anniehedgpeth
Copy link
Contributor

CI: Build Status

This example provisions and deploys the following resources into an Azure subscription:

  • Resource Group
  • VNET
  • Subnet
  • NIC
  • PIP
  • Storage Account
  • VM from user image

CI process:

terraform get, validate, plan to output, apply output, show
validate with azure CLI
terraform destroy

anniehedgpeth and others added 30 commits April 17, 2017 19:07
…t script, added mac specific deployment for local testing
* initial commit - 101-vm-from-user-image
* added tfvars and info for README
* added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing
* prep for PR
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anniehedgpeth

Thanks for this PR - I've reviewed inline and left a couple of comments - but this generally looks good to me :)

Thanks!

}

variable "admin_password" {
description = "administrator password (recommended to disable password auth)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

administrator password (recommended to disable password auth)

Is it worth rephrasing this to make it clearer? Something like "The Password for the account specified in the admin_username field. We recommend disabling Password Authentication in a Production environment"?

--workdir=/data \
--entrypoint "/bin/sh" \
hashicorp/terraform:light \
-c "/bin/terraform destroy -force \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we shouldn't need to specify the individual resources as targets here, as deleting the resource group will force the deletion of any child resources?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tombuildsstuff , we did that because we are targeting specific resources for our CI process, because we depend on an image in that resource group, and this helps to ensure that we don't remove it in addition to other mechanisms in place.

@stack72
Copy link
Contributor

stack72 commented May 11, 2017

LGTM thanks for the followup work here :)

@stack72 stack72 merged commit 4435f43 into hashicorp:master May 11, 2017
@anniehedgpeth anniehedgpeth deleted the hashicorp-101-vm-from-user-image branch June 16, 2017 14:05
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants