-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/azurerm: Add example of vm from user image #14231
provider/azurerm: Add example of vm from user image #14231
Conversation
…t script, added mac specific deployment for local testing
…hmagnitude/terraform into topic-101-vm-from-user-image
* initial commit - 101-vm-from-user-image * added tfvars and info for README * added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing * prep for PR
… ci process; added os_profile_linux_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR - I've reviewed inline and left a couple of comments - but this generally looks good to me :)
Thanks!
} | ||
|
||
variable "admin_password" { | ||
description = "administrator password (recommended to disable password auth)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
administrator password (recommended to disable password auth)
Is it worth rephrasing this to make it clearer? Something like "The Password for the account specified in the admin_username
field. We recommend disabling Password Authentication in a Production environment"?
--workdir=/data \ | ||
--entrypoint "/bin/sh" \ | ||
hashicorp/terraform:light \ | ||
-c "/bin/terraform destroy -force \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we shouldn't need to specify the individual resources as targets here, as deleting the resource group will force the deletion of any child resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tombuildsstuff , we did that because we are targeting specific resources for our CI process, because we depend on an image in that resource group, and this helps to ensure that we don't remove it in addition to other mechanisms in place.
LGTM thanks for the followup work here :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
CI:
This example provisions and deploys the following resources into an Azure subscription:
CI process: