-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/google: Improve Google provider documentation #14028
Conversation
4341560
to
f5b9554
Compare
As @davejlong pointed out in #12617 (comment) Google seems to have changed the API slightly removing support for machine types in Postgres. I suppose this means we cannot merge this one yet. |
f5b9554
to
ec1ac60
Compare
I added the findings from #12617 (comment) to the documentation. Not sure though if the terraform docs really want to document a feature which is totally undocumented on the Google-Side 😼 |
As mentioned in hashicorp#12617 the google_sql_database_instance resource already supports `POSTGRES_9_6` as `database_version`, it is just undocumented so far.
Looks like this is a relict from some copy & paste from `google_storage_*` while writing the docs for `google_sql_database`.
ccff20d
to
462518f
Compare
@danawillow @paddycarver sorry for bumping this, but is there any interest in merging these additions to the terraform docs? I can would assume that some terraform users would be happy to give CloudSQL Postgres a try… |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Add two small improvements to the google provider docs.