Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Improve Google provider documentation #14028

Closed
wants to merge 3 commits into from

Conversation

ctavan
Copy link
Contributor

@ctavan ctavan commented Apr 27, 2017

Add two small improvements to the google provider docs.

@ctavan ctavan changed the title Improve google docs provider/google: Improve Google provider documentation Apr 27, 2017
@ctavan ctavan force-pushed the improve-google-docs branch from 4341560 to f5b9554 Compare April 28, 2017 12:08
@ctavan
Copy link
Contributor Author

ctavan commented May 2, 2017

As @davejlong pointed out in #12617 (comment) Google seems to have changed the API slightly removing support for machine types in Postgres. I suppose this means we cannot merge this one yet.

@ctavan ctavan force-pushed the improve-google-docs branch from f5b9554 to ec1ac60 Compare May 2, 2017 12:29
@ctavan
Copy link
Contributor Author

ctavan commented May 2, 2017

I added the findings from #12617 (comment) to the documentation. Not sure though if the terraform docs really want to document a feature which is totally undocumented on the Google-Side 😼

@danawillow danawillow requested a review from paddycarver May 18, 2017 19:56
ctavan added 3 commits May 26, 2017 11:41
As mentioned in hashicorp#12617 the
google_sql_database_instance resource already supports `POSTGRES_9_6` as
`database_version`, it is just undocumented so far.
Looks like this is a relict from some copy & paste from
`google_storage_*` while writing the docs for `google_sql_database`.
@ctavan ctavan force-pushed the improve-google-docs branch from ccff20d to 462518f Compare May 26, 2017 09:41
@ctavan
Copy link
Contributor Author

ctavan commented May 26, 2017

@danawillow @paddycarver sorry for bumping this, but is there any interest in merging these additions to the terraform docs? I can would assume that some terraform users would be happy to give CloudSQL Postgres a try…

@ctavan
Copy link
Contributor Author

ctavan commented Jun 14, 2017

@ctavan ctavan closed this Jun 14, 2017
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants