Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: replace instance group manager urls with instance group urls in container cluster tests #12991

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

danawillow
Copy link
Contributor

Follow-up to #12486. Fixes a bunch of currently-failing tests because of the interaction between #12486 and #12147.

@danawillow
Copy link
Contributor Author

TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccContainerCluster -timeout 120m
=== RUN   TestAccContainerCluster_basic
--- PASS: TestAccContainerCluster_basic (334.04s)
=== RUN   TestAccContainerCluster_withAdditionalZones
--- PASS: TestAccContainerCluster_withAdditionalZones (385.93s)
=== RUN   TestAccContainerCluster_withVersion
--- FAIL: TestAccContainerCluster_withVersion (0.40s)
	testing.go:273: Step 0 error: Error applying: 1 error(s) occurred:

		* google_container_cluster.with_version: 1 error(s) occurred:

		* google_container_cluster.with_version: googleapi: Error 400: Version is invalid., badRequest
=== RUN   TestAccContainerCluster_withNodeConfig
--- PASS: TestAccContainerCluster_withNodeConfig (343.54s)
=== RUN   TestAccContainerCluster_withNodeConfigScopeAlias
--- PASS: TestAccContainerCluster_withNodeConfigScopeAlias (323.48s)
=== RUN   TestAccContainerCluster_network
--- PASS: TestAccContainerCluster_network (385.83s)
=== RUN   TestAccContainerCluster_backend
--- PASS: TestAccContainerCluster_backend (316.05s)

(the version one will clearly have a different fix)

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge at will. Thank you for greening tests, you're the best. 😁

@danawillow danawillow merged commit b18fb29 into hashicorp:master Mar 23, 2017
@danawillow danawillow deleted the igm-urls branch March 23, 2017 00:46
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants