provider/vsphere Change default adapter_type to lsiLogic

[ewypych]

It's a very small, but very important change in my opinion.

There is no logical reason for setting up "ide" as the default adapter_type. This controller type is useless in the VMware world - disk cannot be resized, has less performance etc. Most of the OSes have drivers for vSCSI controllers and VMware recommends to convert every IDE disk to SCSI. Only for old Operating Systems (like virtualized Windows XP) there is a sense in using IDE. Of course after converting P2V, VM has IDE controller, but VMware recommends to convert IDE to SCSI too.

I have changed default adapter_type in the resource_vsphere_virtual_disk.go to "lsiLogic". Most of the operating systems have LSI Logic SCSI drivers. LSI Logic Parallel and LSI Logic SAS are being the most frequently used controllers now. Sometimes one can see BusLogic, but it's not as popular as LSI Logic SCSI. So, I think it's a very useful change - now there is a necessity of manual changing adapter_type in every infrastructure configuration. With 'lsiLogic' by the default, life would be simpler. 😃

[ewypych]

Migrated to terraform-providers/terraform-provider-vsphere#94.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.