provider/google: ignore expanded v collapsed policies in diff

[paddycarver]

When comparing the config and state for google_project_iam_policy,
always merge the bindings down to a common representation, to avoid a
perpetual diff.

Fixes #11763.

I also added a test to ensure the fix worked. Output of the test without the fix in place:

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/02 13:59:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccGoogleProjectIamPolicy_expanded -timeout 120m
=== RUN   TestAccGoogleProjectIamPolicy_expanded
--- FAIL: TestAccGoogleProjectIamPolicy_expanded (20.58s)
        testing.go:265: Step 0 error: After applying this step, the plan was not empty:

                DIFF:

                UPDATE: google_project_iam_policy.acceptance
                  policy_data: "{\"bindings\":[{\"members\":[\"user:[email protected]\",\"user:[email protected]\"],\"role\":\"roles/viewer\"}]}" => "{\"bindings\":[{\"members\":[\"user:[email protected]\"],\"role\":\"roles/viewer\"},{\"members\":[\"user:[email protected]\"],\"role\":\"roles/viewer\"}]}"

                STATE:

                data.google_iam_policy.expanded:
                  ID = 1322415602
                  binding.# = 2
                  binding.1102091722.members.# = 1
                  binding.1102091722.members.2912398366 = user:[email protected]
                  binding.1102091722.role = roles/viewer
                  binding.4049261743.members.# = 1
                  binding.4049261743.members.360503667 = user:[email protected]
                  binding.4049261743.role = roles/viewer
                  policy_data = {"bindings":[{"members":["user:[email protected]"],"role":"roles/viewer"},{"members":["user:[email protected]"],"role":"roles/viewer"}]}
                google_project.acceptance:
                  ID = terraform-pjewz40hq3
                  name = Terraform Acceptance Tests
                  number = 609045719484
                  org_id = 622235425790
                  project_id = terraform-pjewz40hq3
                google_project_iam_policy.acceptance:
                  ID = terraform-pjewz40hq3
                  authoritative = false
                  etag = BwVJxo1shsw=
                  policy_data = {"bindings":[{"members":["user:[email protected]","user:[email protected]"],"role":"roles/viewer"}]}
                  project = terraform-pjewz40hq3
                  restore_policy = {"bindings":[{"members":["serviceAccount:terraform-acceptance-tests@hc-terraform-testing.iam.gserviceaccount.com"],"role":"roles/owner"}],"etag":"BwVJxo0AAQ4=","version":1}

                  Dependencies:
                    google_project.acceptance
                    data.google_iam_policy.expanded
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/google 20.584s
Makefile:48: recipe for target 'testacc' failed
make: *** [testacc] Error 1

Output after fix:

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/02 14:00:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccGoogleProjectIamPolicy_expanded -timeout 120m
=== RUN   TestAccGoogleProjectIamPolicy_expanded
--- PASS: TestAccGoogleProjectIamPolicy_expanded (19.65s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 19.659s

[danawillow]

A lot of the error checking in this function is duplicated from testAccCheckGoogleProjectIamPolicyExists, which is called from this fn. I wouldn't mind seeing something like (either or some combination of):

• The error-checking is removed from this function since calling the other one takes care of it
• A helper function could take care of getting the projectP and policyP values (and doing the error-checking) that gets called from both functions

[danawillow]

nit: indentation (make this spaces instead of tabs)

[danawillow]

and here

[paddycarver]

Comments should be addressed. :)

[danawillow]

Looks good, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.