provider/aws: Add import to aws_iam_role_policy_attachment

[jzbruno]

Fixes #12100.

This is a working implementation of import for aws_iam_role_policy_attachment. But I have an implementation question.

Due to how the resource ID is generated in the current aws_iam_role_policy_attachment an import test cannot pass. This is because the resource ID is generated using resource.PrefixedUniqueId. If the we use the same function in the import to make the ID consistent the test will also get a unique ID and can't be verified.

To make the test pass I changed aws_iam_role_policy_attachment resource ID generation to use the role name combined with the policy arn.

How should we proceed with this? Any suggestions.

Thanks.

[GuiSim]

I'd love this to be merged! I would have used this feature today. Any chances this can be merged?

[jamesbrown7]

Agreed, it would be very helpful to get this merged, I could use it right away!

[Ninir]

Hey @jzbruno

Could you migrate this to https://github.com/terraform-providers/terraform-provider-aws, which is the AWS-reference repository?
Would be really appreciated so that people, including me, are able to review & merge it.

Thanks! 😄

[jzbruno]

Sure thing. I'll do that either tomorrow or Saturday if I have time. Jack

…

On Aug 10, 2017, at 12:10 AM, Gauthier Wallet ***@***.***> wrote: Hey @jzbruno Could you migrate this to https://github.com/terraform-providers/terraform-provider-aws, which is the AWS-reference repository? Would be really appreciated so that people, including me, are able to review & merge it. Thanks! 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[apparentlymart]

Hello @jzbruno, and thanks for working on this!

As part of the the Terraform 0.10 release earlier this year, all of the Terraform providers were moved to their own repositories in the terraform-providers GitHub organization, and removed from the Terraform Core repository.

Unfortunately due to the fact that new issues and pull requests are being opened constantly, it was not possible for the various provider maintainers to merge all outstanding pull requests before this split, and there is no automatic way to migrate a pull request to a new repository.

As a result, this pull request can sadly no longer be applied as-is, and so I'm going to close it.

As suggested by @Ninir above, if you or someone else has the time and motivation to apply same changes to the aws provider repository and open a new PR there, the maintainers of that provider should be able to review and merge it.

Thanks again for working on this, and sorry it was not able to be merged before the provider repository changes.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.