Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws: Add 'aws_default_vpc' resource #11710

Merged
merged 1 commit into from
May 17, 2017
Merged

resource/aws: Add 'aws_default_vpc' resource #11710

merged 1 commit into from
May 17, 2017

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 5, 2017

Provides a resource to manage the default AWS VPC in the current region.
Acceptance tests:

make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSDefaultVpc_'

@ewbankkit
Copy link
Contributor Author

  • Rebased to remove merge conflicts
  • Added example to documentation

@ewbankkit ewbankkit changed the title [WIP] resource/aws: Add 'aws_default_vpc' resource resource/aws: Add 'aws_default_vpc' resource Feb 10, 2017
@ewbankkit
Copy link
Contributor Author

Removing WIP.

@ewbankkit
Copy link
Contributor Author

Rebased and added support for IPv6 attributes.

@ewbankkit
Copy link
Contributor Author

Rebased and aligned acceptance tests with recent changes to aws_vpc resource.
Acceptance test output:

$ make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSDefaultVpc_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/16 20:00:53 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws/ -v -run=TestAccAWSDefaultVpc_ -timeout 120m
=== RUN   TestAccAWSDefaultVpc_basic
--- PASS: TestAccAWSDefaultVpc_basic (22.36s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	22.366s

@ewbankkit
Copy link
Contributor Author

@stack72 Any chance of a review on this one? Thanks

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@grubernaut grubernaut merged commit da2659b into hashicorp:master May 17, 2017
@ewbankkit ewbankkit deleted the aws_default_vpc-resource branch May 19, 2017 17:47
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants