core: Refresh, Validate, Input on new graph builders #11426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was possible with test fixtures but it is also conceiably possible with older states or corrupted states. We can also extract the type from the key so we do that now so that StateFilter is more robust.
We forgot to wrap some changes from the old branch into the new style
jbardin
approved these changes
Jan 26, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the refresh, validate, and input graphs to use a new custom graph builder. This work is just continuing the work I started and shipped for 0.8 but on the less complex and less dangerous graphs. See #9973 or #9388 as prior examples.
The goal at this point now that plan/apply have shipped on new graphs is to complete the less dangerous graphs so we can ultimately fully remove the legacy graph building code. This PR completes that.
The changes are relatively minimal given we're doing three graphs.
What this PR changes/adds:
StateFiltermade more robust to handle cases where state may not have resource type. This was necessary for tests to pass without changes.ConfigTransformercan filter the types of things added. This was necessary to add only data sources for refresh.EvalValidateResourceSelfRefis added since our new graph builder never creates edges to self (prior one did and we caught those errors at the graph cycle layer)This PR does not enable/use the shadow graph. Refresh, validate, input are not scary operations (compared to plan/apply) and therefore we won't be using the shadow graph for this. We'll be shipping it default-on in 0.9 betas and let any bugs come through there.