-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error creating backend service #4336
Comments
I'm not familiar offhand with this API, but perhaps @lwander can shed some light on this? |
@yosssi, this looks like a bug with the Google API. The |
@lwander Thanks for your investigation. I understand. I hope this bug will be fixed. |
@lwander any updates on this? |
No, nothing yet. I'm hesitant to fix this on the Terraform end, since it will only break again once the API is fixed. |
@lwander Makes sense, thanks for the quick response!
If you take that last part of the url: gke-your_cluster_name_here-hash_key_here-group, you can put it into the correct API url form specified in the instance group API docs: I had to put this in parentheses so the link wouldn't highlight - Then you can hardcode in the group value:
|
@dcgoss Thus, just replacing "instanceGroupManagers" with "instanceGroups", it works.
That's it. |
@lwander would a possible way forward on this issue be to examine the URL we're getting back from the API, attempt to parse it according to the known format ( |
Hey @paddyforan, rather than do string substitution on matching URLs it would be neater to lookup the returned instance group manager to read which instance group it's managing, and then supply that. Depending on naming conventions feels brittle. |
Hey @lwander, you're right, that does feel more robust, though it comes at the cost of an extra network request. In this case, I feel like the network request is worthwhile, even though we still need to rely on naming conventions to detect that the API has not been fixed, unless I'm missing something. I'll try to get a test case for this that fails, then get it fixed. Can't promise an ETA on the PR (I'm still in catch-up mode after the holiday) but hopefully I'll get to this soon. If anyone beats me to the punch, I'm happy to review. |
Sounds great, thanks @paddyforan |
Google Container Engine's cluster API returned instance group manager URLs when it meant to return instance group URLs. See #4336 for details about the bug. While this is undeniably an upstream problem, this PR: * detects the error, meaning it will work as expected when the API is fixed. * corrects the error by requesting the instance group manager, then retrieving its instance group URL, and using that instead. * adds a test that exercises the error and the solution, to ensure it is functioning properly.
I have, at long last, opened a PR with the change. Apologies for the delay. I tagged you for a review, @lwander, as you seemed the most knowledgeable about it, but if you don't have time, there are others that can review. :) |
PR just landed in master. This should be fixed in our next release. Thanks for the patience, and for reporting! |
@paddycarver have you by any chance asked Google folks to solve this issue upstream? would be curious to join in on the conversation |
I, unfortunately, don't quite recall--it's not showing up in my https://issuetracker.google.com history, which means if I did, I did so through an informal back-channel and don't have a link, anyways. :( If you're interested in it, I'd definitely suggest opening an issue on https://issuetracker.google.com! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I got the following error when I try to create a backend service:
Following is my template:
I don't know why this kind of error occurs and how to fix it.
What is the reason of this error and how can I fix it?
Thanks.
The text was updated successfully, but these errors were encountered: