Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Library #985

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Content Library #985

merged 4 commits into from
Mar 19, 2020

Conversation

bill-rich
Copy link
Contributor

Adding support for content library as a resource, data source, and clone source for virtual machines.

@ghost ghost added the size/xl Relative Sizing: Extra-Large label Mar 4, 2020
vsphere/resource_vsphere_content_library.go Show resolved Hide resolved
vsphere/resource_vsphere_content_library.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_content_library_item.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_virtual_machine.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_virtual_machine.go Outdated Show resolved Hide resolved
@aareet aareet linked an issue Mar 6, 2020 that may be closed by this pull request
@ghost ghost added the documentation Type: Documentation label Mar 16, 2020
@bill-rich bill-rich changed the title Content Library [WIP] Content Library Mar 17, 2020
Copy link
Contributor

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are minor (just a couple of typos and a documentation improvement).

I have a question though. I see that in order to create a content library we need to pass a datastore and these are datacenter specific. The data resource on the other hand (as well as the underlying code all the way down to the point we call vmomi) does not seem to be looking for a datacenter.

Are content library names global, regardless of their location ? Or should we account for the case where we have two content libraries with the same name backed on different datacenters, or even on the same DC but with different backing datastores.

website/docs/r/content_library.html.markdown Outdated Show resolved Hide resolved
@ghost ghost added size/xxl Relative Sizing: Extra-Extra-Large and removed size/xl Relative Sizing: Extra-Large labels Mar 18, 2020
@bill-rich
Copy link
Contributor Author

Content Libraries are at the vCenter level, so they're above datacenters in the tree. The naming thing is kind of an odd one. You can have two Content Libraries with the same name, but the GetLibraryByName function in govmomi returns the first one it comes accross with a matching name. We could use one of the listing functions to get the whole list back and filter by other criteria, but I think the use case of multiple libraries with the same name is going to be pretty uncommon.

@ghost ghost added the dependencies Type: Dependencies label Mar 19, 2020
Copy link
Contributor

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bill-rich bill-rich merged commit e870613 into master Mar 19, 2020
@bill-rich bill-rich deleted the f-content-library branch March 19, 2020 19:25
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Type: Dependencies documentation Type: Documentation size/xxl Relative Sizing: Extra-Extra-Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Template Deployment from VMWare Content Library
2 participants