-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Library #985
Content Library #985
Conversation
745aa7a
to
839b3e0
Compare
839b3e0
to
6bfedb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes are minor (just a couple of typos and a documentation improvement).
I have a question though. I see that in order to create a content library we need to pass a datastore and these are datacenter specific. The data resource on the other hand (as well as the underlying code all the way down to the point we call vmomi) does not seem to be looking for a datacenter.
Are content library names global, regardless of their location ? Or should we account for the case where we have two content libraries with the same name backed on different datacenters, or even on the same DC but with different backing datastores.
vsphere/internal/helper/contentlibrary/content_library_helper.go
Outdated
Show resolved
Hide resolved
vsphere/internal/helper/virtualmachine/virtual_machine_helper.go
Outdated
Show resolved
Hide resolved
6bfedb1
to
a85c2f7
Compare
Content Libraries are at the vCenter level, so they're above datacenters in the tree. The naming thing is kind of an odd one. You can have two Content Libraries with the same name, but the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Adding support for content library as a resource, data source, and clone source for virtual machines.