Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base storage_policy_id off vm #970

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Base storage_policy_id off vm #970

merged 1 commit into from
Feb 6, 2020

Conversation

bill-rich
Copy link
Contributor

Set the storage_policy_id based off the VM uuid rather than the template.

@bill-rich bill-rich requested a review from a team February 6, 2020 18:51
@ghost ghost added the size/xs Relative Sizing: Extra-Small label Feb 6, 2020
@bill-rich bill-rich force-pushed the b-fix_spbm_template_dependency branch from f0ef514 to 650faa0 Compare February 6, 2020 19:39
koikonom
koikonom approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bill-rich
Copy link
Contributor Author

Fixes #968

@bill-rich bill-rich merged commit 5c41ac2 into master Feb 6, 2020
@bill-rich bill-rich deleted the b-fix_spbm_template_dependency branch February 6, 2020 20:09
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koikonom koikonom koikonom approved these changes

Assignees
No one assigned
Labels
size/xs Relative Sizing: Extra-Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bill-rich @koikonom