Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use govmomi REST client #955

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Use govmomi REST client #955

merged 2 commits into from
Jan 24, 2020

Conversation

bill-rich
Copy link
Contributor

No description provided.

@bill-rich bill-rich requested a review from a team January 24, 2020 06:09
@ghost ghost added the size/xxl Relative Sizing: Extra-Extra-Large label Jan 24, 2020
koikonom
koikonom approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky #2 :)

@koikonom koikonom force-pushed the f-use_govmomi_rest_client branch from 59d638a to 1cb16d2 Compare January 24, 2020 09:17
@koikonom
Copy link
Contributor

There were some conflicts on go.mod and go.sum that I couldn't for some reason fix via the UI, so I did it on my local branch, rebased on top of origin/master and then pushed with --force-with-lease.

@koikonom koikonom merged commit 05cd12c into master Jan 24, 2020
@koikonom koikonom deleted the f-use_govmomi_rest_client branch January 24, 2020 09:20
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koikonom koikonom koikonom approved these changes

Assignees
No one assigned
Labels
size/xxl Relative Sizing: Extra-Extra-Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bill-rich @koikonom