Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/virtual_machine: Ignore validation when interpolation not available #784

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

bill-rich
Copy link
Contributor

Use NewValueKnown to check if value is empty because of interpolation not being available at diff time. Specifically to fix issues where CustomizeDiff function returns an error because values that are based on computed values from new resources appear empty during diff.

Fixes #778

Use NewValueKnown to check if value is empty because of interpolation
not being available at diff time. Specifically to fix issues where
CustomizeDiff function returns an error because values that are based on
computed values from new resources appear empty during diff.
@bill-rich bill-rich requested a review from a team June 5, 2019 22:59
@ghost ghost added the size/xl Relative Sizing: Extra-Large label Jun 5, 2019
Copy link

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bill-rich bill-rich merged commit 91ffd0b into master Jun 17, 2019
@bill-rich bill-rich deleted the b-computed_customization_spec branch June 17, 2019 23:36
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/xl Relative Sizing: Extra-Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Computed windows_sysprep_text failing validation
2 participants