vendor: Update govmomi to bb8ff8d #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes vmware/govmomi#1034, which fixes opaque network support, ultimately allowing managed VMs to correctly work with NSX-T logical switches. A couple of minor code updates have been included to reflect updates to some types and signatures.
tombuildsstuff
approved these changes
Feb 13, 2018
| "revision": "d68562200280ff2ad2110719b06496c9e9526118", | ||
| "revisionTime": "2017-10-13T00:55:03Z" | ||
| "revision": "bb8ff8d53171157123ae812088fd06223d8d90a3", | ||
| "revisionTime": "2018-02-13T04:10:52Z" |
There was a problem hiding this comment.
should we not be pinning to the tag of 0.16.0?
There was a problem hiding this comment.
Releases in govmomi generally are only useful for govc. The SDK is unversioned. As an example, 0.16.0 was actually released back in November.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes vmware/govmomi#1034, which fixes opaque network support,
ultimately allowing managed VMs to correctly work with NSX-T logical
switches.
A couple of minor code updates have been included to reflect updates to
some types and signatures.