Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare for VM Config spec change #1361

Merged
merged 1 commit into from
May 7, 2021

Conversation

k-chu
Copy link
Contributor

@k-chu k-chu commented Mar 9, 2021

This PR fixes an issue reported in #1266.

When a Virtual Machine is imported, and then a plan/apply is run without any changes to the template, the VM is started after apply. This started happening in v1.17.4 and is still present in the latest provider. This appears to be a side effect from a different fix #1055

@ghost ghost added the size/xs Relative Sizing: Extra-Small label Mar 9, 2021
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 9, 2021

CLA assistant check
All committers have signed the CLA.

@ifwatts
Copy link

ifwatts commented Apr 27, 2021

@hashicorp-cla is there any timeline for this to be merged? There are customers experiencing this issue today and we want to resolve that as soon as possible.

@ifwatts
Copy link

ifwatts commented Apr 27, 2021

@koikonom is there some process needed to be done to have this merged?

Copy link
Contributor

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@koikonom koikonom merged commit 814b153 into hashicorp:master May 7, 2021
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants