Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/host_port_group: Add support for importing #1194

Merged
merged 3 commits into from
Sep 17, 2020
Merged

r/host_port_group: Add support for importing #1194

merged 3 commits into from
Sep 17, 2020

Conversation

waquidvp
Copy link
Contributor

@waquidvp waquidvp commented Sep 1, 2020 •
edited
Loading

Description

Adds support for importing vsphere_host_port_group.

Bonus: Fix typo in the vnic import documentation.

TODO

  • Update docs

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

Release Note

Release note for CHANGELOG:

`resource/host_port_group`: Add support for importing host port group.

@waquidvp waquidvp force-pushed the import-host-port-group branch from 3f13f8e to 6455737 Compare September 6, 2020 10:35
@ghost ghost added size/xs Relative Sizing: Extra-Small labels Sep 6, 2020
@ghost ghost added size/s Relative Sizing: Small documentation Type: Documentation and removed size/xs Relative Sizing: Extra-Small labels Sep 6, 2020
@waquidvp waquidvp changed the title Import host port group r/host_port_group: Add support for importing Sep 7, 2020
@bill-rich bill-rich merged commit a88bf6b into hashicorp:master Sep 17, 2020
@ghost
Copy link

ghost commented Oct 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
documentation Type: Documentation size/s Relative Sizing: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waquidvp @bill-rich