r/vm: Support hardware versions #1020
Conversation
ghost
added
size/xl
| log.Printf("[DEBUG] Upgrading virtual machine %q", vm.InventoryPath) | ||
| ctx, cancel := context.WithTimeout(context.Background(), provider.DefaultAPITimeout) | ||
| defer cancel() | ||
| vm.UpgradeVM(ctx, GetHardwareVersionID(version)) |
There was a problem hiding this comment.
Should we be checking the current version of the VM before upgrading? What if the VM has a later newer version or the same version?
There was a problem hiding this comment.
This is actually an orphaned function. SetHardwareVersion is what is actually used, and it does validate the versions. Just got this one removed.
| @@ -609,6 +609,11 @@ func resourceVSphereVirtualMachineUpdate(d *schema.ResourceData, meta interface{ | |||
| return err | |||
| } | |||
| // Only carry out the reconfigure if we actually have a change to process. | |||
| cv := virtualmachine.GetHardwareVersionNumber(vprops.Config.Version) | |||
| tv := d.Get("hardware_version").(int) | |||
There was a problem hiding this comment.
What's the default value if there is no hardware version set? 0 ?
There was a problem hiding this comment.
Correct. The default value is 0.
|
Fixes #1000 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.