Update deleteFile function methods

A destroy would complete as a false positive when deleting a .`vmdk` and would leave the file since the `DeleteDatastoreFile_Task `could not delete a VMDK.

This change updates the methods used in the `deleteFile` function.
- If the source file is a `.vmdk`, the Delete method uses the correct `DeleteVirtualDisk_Task`.
- If the source file is not a `.vmdk`, the Delete method uses the correct `DeleteDatastoreFile_Task`.

Signed-off-by: Ryan Johnson <[email protected]>

vsphere/resource_vsphere_file.go

@@ -392,6 +392,7 @@ func resourceVSphereFileDelete(d *schema.ResourceData, meta interface{}) error {
 }
 
 func deleteFile(client *govmomi.Client, f *file) error {
+
 	dc, err := getDatacenter(client, f.datacenter)
 	if err != nil {
 		return err
@@ -405,17 +406,36 @@ func deleteFile(client *govmomi.Client, f *file) error {
 		return fmt.Errorf("error %s", err)
 	}
 
-	fm := object.NewFileManager(client.Client)
-	task, err := fm.DeleteDatastoreFile(context.TODO(), ds.Path(f.destinationFile), dc)
-	if err != nil {
-		return err
-	}
+	// If the source file is a VMDK, the Delete method uses the correct DeleteVirtualDisk_Task
+	if path.Ext(f.destinationFile) == ".vmdk" {
+		vdm := object.NewVirtualDiskManager(client.Client)
+		task, err := vdm.DeleteVirtualDisk(context.TODO(), ds.Path(f.destinationFile), dc)
+		if err != nil {
+			return err
+		}
+
+		_, err = task.WaitForResult(context.TODO(), nil)
+		if err != nil {
+			return err
+		}
+		return nil
+
+	} else {
+		// If the source file is not a VMDK, the Delete method uses the correct DeleteDatastoreFile_Task
+		fm := object.NewFileManager(client.Client)
+		task, err := fm.DeleteDatastoreFile(context.TODO(), ds.Path(f.destinationFile), dc)
+		if err != nil {
+			return err
+		}
+
+		_, err = task.WaitForResult(context.TODO(), nil)
+		if err != nil {
+			return err
+		}
+		return nil
 
-	_, err = task.WaitForResult(context.TODO(), nil)
-	if err != nil {
-		return err
 	}
-	return nil
+
 }
 
 // getDatastore gets datastore object