Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new resource for password policy #927

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Adding new resource for password policy #927

merged 1 commit into from
Jan 21, 2021

Conversation

petems
Copy link
Contributor

@petems petems commented Dec 4, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #926

Release note for CHANGELOG:

* Adds vault_password_policy resource (closes #926)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
make testacc TESTARGS='-run=TestAccPasswordPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccPasswordPolicy -timeout 120m
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/codegen	0.088s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	1.156s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	1.493s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	2.697s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	0.860s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	0.389s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	2.136s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/util	0.145s [no tests to run]
=== RUN   TestAccPasswordPolicy
--- PASS: TestAccPasswordPolicy (0.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	2.212s
...

@jasonodonnell jasonodonnell self-requested a review December 14, 2020 20:05
@petems petems force-pushed the add_password_policy_resource branch 3 times, most recently from e428c3e to a20c4d0 Compare January 21, 2021 01:17
@petems petems force-pushed the add_password_policy_resource branch from a20c4d0 to c3b3c8a Compare January 21, 2021 01:19
@petems
Copy link
Contributor Author

petems commented Jan 21, 2021

@jasonodonnell Mind re-reviewing now? 😄

jasonodonnell
jasonodonnell approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jasonodonnell jasonodonnell merged commit 7ccf476 into hashicorp:master Jan 21, 2021
@petems petems mentioned this pull request Jan 21, 2021
Open
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@petems @jasonodonnell
Adding new resource for password policy (hashicorp#927)
d4eaed5 
* https://www.vaultproject.io/docs/concepts/password-policies

Co-authored-by: Jason O'Donnell <[email protected]>

Co-authored-by: Jason O'Donnell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Feature: Password Policy for Secrets Engines
2 participants
@petems @jasonodonnell