Updating doc for PEM fields that underlying Golang libraries append a \n to
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `\n` to Adding a suggestion to use `trimspace()` in case the generated PEM causes issues.
bendbennett
approved these changes
May 3, 2022
jackivanov
pushed a commit
to jackivanov/terraform-provider-tls
that referenced
this pull request
Aug 4, 2022
… `\n` to (hashicorp#198) Adding a suggestion to use `trimspace()` in case the generated PEM causes issues.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #197
Additional context: #163
Additional context: #9
Relates to: hashicorp/terraform-provider-aws#24025
Adding a suggestion to use
trimspace()in case the generated PEM causes issues.One thing I'm not sure about: does it make sense to mention the underlying libraries that "cause" this, or not.