Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to Go 1.19 #378

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Updating to Go 1.19 #378

merged 1 commit into from
Mar 6, 2023

Conversation

bendbennett
Copy link
Contributor

Closes: #377

@bendbennett bendbennett added dependencies go Pull requests that update Go code labels Mar 3, 2023
@bendbennett bendbennett added this to the v3.5.0 milestone Mar 3, 2023
@bendbennett bendbennett requested a review from a team as a code owner March 3, 2023 16:21
bflad
bflad approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 (this provider is only unit testing with the go.mod version, which is fine for provider codebases)

@bendbennett bendbennett merged commit 60c6f8e into main Mar 6, 2023
@bendbennett bendbennett deleted the bendbennett/issues-377 branch March 6, 2023 07:14
@faarshad faarshad mentioned this pull request Mar 7, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies go Pull requests that update Go code size/XS
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Bump Expected Minimum Go Version to 1.19
2 participants
@bendbennett @bflad