Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

resource/rabbitmq_user - fix password issue when updating user tags #41

Closed

Conversation

heimweh
Copy link
Contributor

@heimweh heimweh commented Oct 11, 2019

This PR fixes #40 by setting the password in the user settings.
Without this, any changes to the tags will break the password for an existing user.

@ghost ghost added the size/XS label Oct 11, 2019
@heimweh
Copy link
Contributor Author

heimweh commented Oct 11, 2019

Tests are passing:

$ make testacc TEST=./rabbitmq
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./rabbitmq -v -count=1 -timeout 120m
=== RUN   TestAccBinding_importBasic
--- PASS: TestAccBinding_importBasic (0.46s)
=== RUN   TestAccExchange_importBasic
--- PASS: TestAccExchange_importBasic (0.38s)
=== RUN   TestAccPermissions_importBasic
--- PASS: TestAccPermissions_importBasic (0.35s)
=== RUN   TestAccPolicy_importBasic
--- PASS: TestAccPolicy_importBasic (0.41s)
=== RUN   TestAccQueue_importBasic
--- PASS: TestAccQueue_importBasic (0.36s)
=== RUN   TestAccUser_importBasic
--- PASS: TestAccUser_importBasic (0.06s)
=== RUN   TestAccVhost_importBasic
--- PASS: TestAccVhost_importBasic (0.32s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccBinding_basic
--- PASS: TestAccBinding_basic (0.41s)
=== RUN   TestAccBinding_slashEscaping
--- PASS: TestAccBinding_slashEscaping (0.45s)
=== RUN   TestAccBinding_propertiesKey
--- PASS: TestAccBinding_propertiesKey (0.41s)
=== RUN   TestAccExchange
--- PASS: TestAccExchange (0.35s)
=== RUN   TestAccPermissions
--- PASS: TestAccPermissions (0.38s)
=== RUN   TestAccPolicy
--- PASS: TestAccPolicy (0.46s)
=== RUN   TestAccQueue_basic
--- PASS: TestAccQueue_basic (0.38s)
=== RUN   TestAccQueue_jsonArguments
--- PASS: TestAccQueue_jsonArguments (0.37s)
=== RUN   TestAccUser_basic
--- PASS: TestAccUser_basic (0.11s)
=== RUN   TestAccUser_emptyTag
--- PASS: TestAccUser_emptyTag (0.13s)
=== RUN   TestAccUser_noTags
--- PASS: TestAccUser_noTags (0.10s)
=== RUN   TestAccUser_passwordChange
--- PASS: TestAccUser_passwordChange (0.10s)
=== RUN   TestAccVhost
--- PASS: TestAccVhost (0.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-rabbitmq/rabbitmq	6.325s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyrilgdn
Copy link
Contributor

cyrilgdn commented Nov 13, 2019

@heimweh FYI #31 was already fixing this (and was adding some unit tests to assert this fix) .

@heimweh
Copy link
Contributor Author

heimweh commented Nov 13, 2019

Hey @cyrilgdn,

Sorry! I must’ve completely missed your fix.
@mbfrahry can you take a look at #31 instead? 🙏

Best,

Alexander

@cyrilgdn
Copy link
Contributor

Hi @heimweh ,

Actually I asked to become a maintainer of this repo (as I was already maintainer of another provider) so I'm now able to manager pull requests.
I'll close this one in favor of #31.

As you worked on this, could you make a review of mine and if it's ok for you we'll merge it.

@cyrilgdn cyrilgdn closed this Nov 25, 2019
@heimweh heimweh deleted the tier/update-tags-passwd-fix branch November 25, 2019 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rabbitmq_user - updating tags clears password
3 participants