This repository has been archived by the owner on Nov 14, 2020. It is now read-only.
[resource_postgresql_default_privileges] add support for types default privileges #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Hi @Vince-Chenal , Sorry for the delay, I totally missed your PR TBH 🤦 We just merged another PR which add the support for functions in Could you just rebase your PR on master to add the support for types and I'll test it/merge it right after. Thanks for this PR and sorry again for the delay. |
…nctions default privileges
Vince-Chenal
changed the title
|
Hey @cyrilgdn , |
cyrilgdn
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
I rebased my branch but I don't really have the time right now to do additional tests.
Thanks a lot @Vince-Chenal , I quickly tested it and it looks good to me 👍
|
FYI, this has just been released in v1.7.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked in this issue, I wanted to add support for functions and types for default privileges.
By the way, those two new objects types also suffers from this issue
I did not know how to test it, I can update the PR if anyone has ideas to improve the PR.