Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensitive_triggers argument #48

Closed
wants to merge 1 commit into from

Conversation

jgiannuzzi
Copy link

This PR adds a sensitive_triggers argument, behaving in the same way as the triggers argument, but with all values marked as sensitive.

Fixes #38.

@bflad
Copy link
Contributor

bflad commented Mar 8, 2023

Hi @jgiannuzzi 👋 Thank you for submitting this and apologies for the delayed review.

Since this was raised, Terraform introduced new functionality for handling sensitive values, including a dedicated sensitive() function to mark values as sensitive and a sensitive attribute on variable blocks. These methodologies are preferred over introducing another attribute into this resource since there is little benefit to having practitioners replace a triggers = sensitive(...) with sensitive_triggers = ..., especially since changing existing configurations would cause resource replacement.

If null_resource is otherwise lacking, Terraform 1.4 was just released with a new terraform_data resource, which may provide benefits for additional use cases.

Thanks again.

@bflad bflad closed this Mar 8, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow defining triggers that are sensitive information
2 participants