provider: don't load namespace from env var #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
added a commit
that referenced
this pull request
Jun 8, 2022
lgfa29
added a commit
that referenced
this pull request
Jun 8, 2022
The Nomad provider doesn't have a global Namespace configuration as each resource may target a different namespace, but the Nomad API client default configuration would load a namespace value from the NOMAD_NAMESPACE automatically. This caused issues in environments where Terraform runs within a Nomad allocation, where the value for NOMAD_NAMESPACE is the namespace of the allocation. Since the namespace value was never supposed to be set at the provider level, this change makes sure the Nomad client namespace is always empty.
jrasell
previously approved these changes
Jun 9, 2022
lgfa29
added a commit
that referenced
this pull request
Aug 25, 2022
Allow users to opt-in into loading the NOMAD_NAMESPACE environment variable. #271 removed this, as this was not intentional, but this value is used in some workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nomad provider doesn't have a global Namespace configuration as each
resource may target a different namespace, but the Nomad API client
default configuration would load a namespace value from the
NOMAD_NAMESPACEautomatically.This caused issues in environments where Terraform runs within a Nomad
allocation, where the value for
NOMAD_NAMESPACEis the namespace of theallocation.
Since the namespace value was never supposed to be set at the provider
level, this change makes sure the Nomad client namespace is always
empty.
Closes #267