Manage quota specifications. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a resource to manage quota specifications, limiting the resources that can be used in a region. The tests for this are 🙀 because sets nested in sets, but... they gave me confidence that it works? 🤷
paultyng
previously requested changes
Feb 16, 2018
| } | ||
| spec.Limits = limits | ||
|
|
||
| // upsert our quota spec |
There was a problem hiding this comment.
Since this is an upsert like the update, could you just called the update here and then SetId? Or add some shared inner func? They appear to be the same code except for some messaging and the SetId.
| if err != nil { | ||
| // As of Nomad 0.4.1, the API client returns an error for 404 | ||
| // rather than a nil result, so we must check this way. | ||
| if strings.Contains(err.Error(), "404") { |
There was a problem hiding this comment.
This is super ugly 😢 is there an issue open on the Nomad API to at least return a named/typed err?
There was a problem hiding this comment.
There is! hashicorp/nomad#1849
paultyng
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a resource to manage quota specifications, limiting the resources
that can be used in a region.
The tests for this are 🙀 because sets nested in sets, but... they gave
me confidence that it works? 🤷