API client (Go) returns error on 404 rather than nil result

[mitchellh]

Nomad version

Output from nomad version

0.4.1

Operating system and Environment details

macOS

Issue

When using the API client package in the api subdir, and making a request such as:

client.Jobs().Info("foo", nil)

where "foo" doesn't exist, it returns an error, rather than a nil job. This makes it difficult to differentiate between a real error and simply a non-existent job.

Reproduction steps

The above states it.

Nomad Server logs (if appropriate)

Not appropriate.

Nomad Client logs (if appropriate)

Not appropriate.

Job file (if appropriate)

None required.