Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying generated kubeconfig file #419

Closed
wants to merge 1 commit into from

Conversation

tennix
Copy link

@tennix tennix commented Apr 29, 2019

This PR fixes #142. When failed to load kubeconfig, fallback to use rest.Config{}.

@ghost ghost added the size/XS label Apr 29, 2019
@jhoblitt
Copy link
Contributor

jhoblitt commented May 2, 2019

What is the result of this change? Would KUBECONFIG from the env be used even when the value of load_config_file = true and config_path = "/dev/null"?

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@aareet
Copy link
Contributor

aareet commented Aug 31, 2020

I'm closing this now since this is attempting to solve an upstream issue - #142 (comment).

@aareet aareet closed this Aug 31, 2020
@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow config_path to be computed
4 participants