Adding ignore_destroy attribute/logic #2588
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2188
This update introduces the
ignore_destroy
attribute to the Kubernetes provider. When set totrue
, it ensures that the resource will only be applied and will not be deleted during a Terraform destroy operation.Important Note:
The
ignore_destroy
attribute only takes effect if the resource is applied with the attribute set to true prior to running a destroy operation. If the attribute is set immediately before the destroy command, it will not have any impact. This limitation arises because, at destroy time, the provider does not have access to the resource's configuration, as nothing is being created. As such, the attribute must be applied during the resource creation phase for it to take effect during subsequent destroy operations.I believe this sort of edge case should be considered when using the
ignore_destroy
attribute, and I will need document the process accordingly in the provider documentation.Acceptance tests
terraform destroy
. the resource is not deleted, but when adding the attribute after the resource is created, the resource is destroyed.Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note