-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
min_ready_seconds parameter support for statefulset #2493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aayush Subramaniam <[email protected]>
Signed-off-by: Aayush Subramaniam <[email protected]>
aayushsss1
force-pushed
the
stateful-set-update
branch
from
May 26, 2024 05:44
9cad52b
to
209e68b
Compare
BBBmau
added
the
no-documentation
This issue or pull request does not have documentation changes.
label
Aug 9, 2024
BBBmau
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only changes needed were on the docs and description so that they match what's seen in the official kubernetes docs
@aayushsss1 Really great work on this! Interested in picking up other issues?
Hey @BBBmau I'd love to! Do let me know if any issues require immediate attention :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minimum ready seconds
.spec.minReadySeconds is an optional field that specifies the minimum number of seconds for which a newly created Pod should be running and ready without any of its containers crashing, for it to be considered available. This is used to check progression of a rollout when using a Rolling Update strategy. This field defaults to 0 (the Pod will be considered available as soon as it is ready). To learn more about when a Pod is considered ready, see Container Probes.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Parameter stable since v1.25 - https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#minimum-ready-seconds
This issue closes #2469
Community Note