Support JobBackoffLimitPerIndex feature gate fields

[theloneexplorerquest]

Description

resolve #2398

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

└─(17:46:40 on Support-JobBackoffLimitPerIndex-feature-gate-fields)──> make testacc TESTARGS='-run TestAccKubernetesCronJobV1_minimalWithBackoffLimitPerIndex'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -vet=off -run TestAccKubernetesCronJobV1_minimalWithBackoffLimitPerIndex -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesCronJobV1_minimalWithBackoffLimitPerIndex
=== PAUSE TestAccKubernetesCronJobV1_minimalWithBackoffLimitPerIndex
=== CONT  TestAccKubernetesCronJobV1_minimalWithBackoffLimitPerIndex
--- PASS: TestAccKubernetesCronJobV1_minimalWithBackoffLimitPerIndex (12.16s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   13.125s

Release Note

Release note for CHANGELOG:

Add `backoff_per_limit_index` and `max_failed_indexes` fields in `structure_job.go`

References

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[alexsomesan]

Thanks a lot for the contribution, @theloneexplorerquest

We have a long standing policy of not including features still behind feature gates, because there is no mechanism available on the Kubernetes API for the provider to query whether the feature gate is on or off and it would lead to unexpected errors on clusters that don't have the feature on.

As I mentioned, we appreciate the contribution and would love to merge this once the feature becomes universally available. Please feel free to keep the PR up to date going forward.

Thanks!

[theloneexplorerquest]

Hi @alexsomesan ,

Thanks for the update, I will keep this open and wait until this feature become universally available (and do more testing at that time!).

[BBBmau]

Looks like there's errors with the PR specifically due to the default value being used. Could you address these failures as well as include a test case for these new fields?

This is now supported with the feature gate being set to true by default. Let me know if there's anything unclear from adding tests.

 === NAME  TestAccKubernetesCronJobV1_minimalWithPodFailurePolicy
    resource_kubernetes_cron_job_v1_test.go:179: Step 1/2 error: Error running apply: exit status 1
        
        Error: CronJob.batch "tf-acc-test-jk4onc8cdw" is invalid: [spec.jobTemplate.spec.backoffLimitPerIndex: Invalid value: 6: requires indexed completion mode, spec.jobTemplate.spec.maxFailedIndexes: Invalid value: 6: requires indexed completion mode]
        
          with kubernetes_cron_job_v1.test,
          on terraform_plugin_test.tf line 1, in resource "kubernetes_cron_job_v1" "test":
           1: resource "kubernetes_cron_job_v1" "test" {

[BBBmau]

any help needed on this @theloneexplorerquest ?

[BBBmau]

just a heads-up I'll be wrapping this up to get it merged as this is part of our v2.33.0 milestone @theloneexplorerquest

[BBBmau]

everything is passing, they weren't prior due to needing to insure that this only runs on tests that have a cluster version of >1.29