Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add conflictsWith to provider schema (#2084)" #2131

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

jrhouston
Copy link
Collaborator

This reverts commit 550f2c1.

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team as a code owner June 5, 2023 12:27
@github-actions github-actions bot added the size/M label Jun 5, 2023
@jrhouston jrhouston force-pushed the hotfix-revert-conflictswith branch from 0d8b9b0 to 3c34d0d Compare June 5, 2023 12:30
@github-actions github-actions bot added size/XS and removed size/M labels Jun 5, 2023
@jrhouston jrhouston force-pushed the hotfix-revert-conflictswith branch from ab3233b to 50e20c6 Compare June 5, 2023 12:35
@github-actions github-actions bot added size/M and removed size/XS labels Jun 5, 2023
@jrhouston jrhouston merged commit 6a417ca into main Jun 5, 2023
@jrhouston jrhouston deleted the hotfix-revert-conflictswith branch June 5, 2023 12:47
@wiebeck
Copy link

wiebeck commented Jun 5, 2023

Now that I've just fixed all my provider configs to work with conflictsWith.... 🙄

@spkane
Copy link

spkane commented Jun 5, 2023

This fixed an issue we ran against on Friday where we were not defining config_path anywhere, but the system would complain that it conflicted with things we were defining like host and client_key. I am assuming that the provider auto-detected something set in the environment like KUBECONFIG and was reading that in as a default config_path and then causing the conflict message to be thrown.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants